Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Streaming's Server Sent Events code #30303

Open
ThisIsMissEm opened this issue May 14, 2024 · 1 comment
Open

Improve Streaming's Server Sent Events code #30303

ThisIsMissEm opened this issue May 14, 2024 · 1 comment
Labels
streaming Streaming server suggestion Feature suggestion

Comments

@ThisIsMissEm
Copy link
Contributor

Pitch

Currently in the streaming server we have a custom Server Sent Events code, which is a little brittle and doesn't give a unified API between our websocket usage and SSE, this complicates a bunch of the downstream code.

Motivation

This resolves some tech debt in the streaming server.

@ThisIsMissEm ThisIsMissEm added the suggestion Feature suggestion label May 14, 2024
@ThisIsMissEm
Copy link
Contributor Author

One option I looked at was using (Hono's SSE)[https://github.com/honojs/hono/blob/main/src/helper/streaming/index.ts] module or HyperExpress's SSE code

Tonight I've come across better-sse which looks really good, and may be better that the other options I'd found. We'd still likely want a small shim to give a consistent API regardless of transport mechanism.

@vmstan vmstan added the streaming Streaming server label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streaming Streaming server suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests

2 participants